Add a test that runs a cairo 0 contract from a cairo program #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fc76a36.
fmoletta
changed the title
fmoletta
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1494 +/- ##
==========================================
+ Coverage 96.81% 96.82% +0.01%
==========================================
Files 96 96
Lines 39684 39684
==========================================
+ Hits 38419 38423 +4
+ Misses 1265 1261 -4 ☔ View full report in Codecov by Sentry. |
fmoletta
requested review from
igaray,
Oppen,
entropidelic,
juanbono and
pefontana
as code owners
Oppen
reviewed
Nov 24, 2023
pefontana
reviewed
Nov 28, 2023
| run_resources: RunResources, | ||
| } | ||
|
|
||
| impl ResourceTracker for SimplifiedOsHintProcessor { |
There was a problem hiding this comment.
I write this comment just to remember,
We should document this trait since developers are going to implement it
Oppen
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends & includes changes from #1492 #1493 #1491
Acts as an example on how to run a cairo 0 contract from a program