Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move iai checkout to the top #1481

Merged
merged 1 commit into from
Nov 14, 2023
Merged

ci: move iai checkout to the top #1481

merged 1 commit into from
Nov 14, 2023

Conversation

Oppen
Copy link
Contributor

@Oppen Oppen commented Nov 14, 2023

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@Oppen Oppen added the pipelines This PR/issue is exclusively about improving our CI label Nov 14, 2023
@Oppen Oppen changed the base branch from main to update-wasm-pack November 14, 2023 16:10
@Oppen Oppen marked this pull request as ready for review November 14, 2023 16:11
Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.528 ± 0.014 2.507 2.552 1.00
head big_factorial 2.553 ± 0.025 2.530 2.618 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.127 ± 0.012 2.115 2.151 1.00
head big_fibonacci 2.152 ± 0.010 2.137 2.171 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 5.883 ± 0.051 5.836 5.987 1.00
head blake2s_integration_benchmark 5.896 ± 0.035 5.860 5.961 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.233 ± 0.013 2.214 2.251 1.01 ± 0.01
head compare_arrays_200000 2.219 ± 0.010 2.205 2.237 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.568 ± 0.014 1.553 1.599 1.00 ± 0.01
head dict_integration_benchmark 1.565 ± 0.010 1.551 1.583 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.045 ± 0.018 1.034 1.093 1.01 ± 0.02
head field_arithmetic_get_square_benchmark 1.039 ± 0.005 1.029 1.045 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 5.887 ± 0.032 5.851 5.954 1.00
head integration_builtins 5.891 ± 0.021 5.853 5.921 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 6.026 ± 0.156 5.933 6.466 1.01 ± 0.03
head keccak_integration_benchmark 5.983 ± 0.032 5.940 6.055 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.244 ± 0.009 2.232 2.262 1.00
head linear_search 2.246 ± 0.013 2.229 2.269 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.544 ± 0.008 1.529 1.558 1.00 ± 0.02
head math_cmp_and_pow_integration_benchmark 1.542 ± 0.026 1.512 1.610 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.471 ± 0.053 1.436 1.617 1.01 ± 0.04
head math_integration_benchmark 1.463 ± 0.019 1.441 1.495 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.286 ± 0.004 1.276 1.289 1.01 ± 0.01
head memory_integration_benchmark 1.279 ± 0.010 1.266 1.296 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.411 ± 0.013 1.400 1.447 1.00
head operations_with_data_structures_benchmarks 1.424 ± 0.010 1.413 1.448 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 578.6 ± 1.8 576.1 581.9 1.00
head pedersen 580.8 ± 3.1 577.3 588.7 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.166 ± 0.005 1.160 1.180 1.00 ± 0.01
head poseidon_integration_benchmark 1.166 ± 0.010 1.159 1.192 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.998 ± 0.007 1.989 2.007 1.00
head secp_integration_benchmark 2.001 ± 0.017 1.989 2.036 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.139 ± 0.011 1.132 1.169 1.00
head set_integration_benchmark 1.139 ± 0.011 1.125 1.163 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 3.799 ± 0.049 3.751 3.931 1.00 ± 0.01
head uint256_integration_benchmark 3.783 ± 0.027 3.737 3.823 1.00

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (22f08f5) 96.82% compared to head (a0bb77d) 96.82%.
Report is 4 commits behind head on update-wasm-pack.

Additional details and impacted files
@@                Coverage Diff                @@
##           update-wasm-pack    #1481   +/-   ##
=================================================
  Coverage             96.82%   96.82%           
=================================================
  Files                    95       95           
  Lines                 39451    39451           
=================================================
  Hits                  38199    38199           
  Misses                 1252     1252           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pefontana pefontana merged commit ec657be into update-wasm-pack Nov 14, 2023
50 of 52 checks passed
@pefontana pefontana deleted the ci/iai_fixes branch November 14, 2023 16:37
github-merge-queue bot pushed a commit that referenced this pull request Nov 14, 2023
* Update wasm-pack version

* Update rust-toolchain for cairo 1 programs

* Update iai-callgrind-runner version

* Revert "Update iai-callgrind-runner version"

This reverts commit 254ad07.

* ci: move iai checkout to the top (#1481)

---------

Co-authored-by: Mario Rugiero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipelines This PR/issue is exclusively about improving our CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants