Skip to content

Commit

Permalink
small fix to cancel duplicate workflow file (#1497)
Browse files Browse the repository at this point in the history
* fix the cancel duplicate job

* remove cancel duplicate for bench

* remove cancel_duplicates workflow

* changelog

* update concurrency setting
  • Loading branch information
greged93 authored Dec 4, 2023
1 parent 8887e60 commit db708e3
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 26 deletions.
25 changes: 0 additions & 25 deletions .github/workflows/cancel_duplicate.yml

This file was deleted.

4 changes: 4 additions & 0 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ on:
pull_request:
branches: [ '**' ]

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

env:
CARGO_TERM_COLOR: always
CAIRO_PROGRAMS_PATH: |
Expand Down
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,15 @@

#### Upcoming Changes

* chore: remove cancel-duplicates workflow [#1497](https://github.com/lambdaclass/cairo-vm/pull/1497)

* feat: Handle `pc`s outside of program segment in `VmException` [#1501] (https://github.com/lambdaclass/cairo-vm/pull/1501)

* `VmException` now shows the full pc value instead of just the offset (`VmException.pc` field type changed to `Relocatable`)
* `VmException.traceback` now shows the full pc value for each entry instead of hardcoding its index to 0.
* Disable debug information for errors produced when `pc` is outside of the program segment (segment_index != 0). `VmException` fields `inst_location` & `error_attr_value` will be `None` in such case.

* feat: Allow running instructions from pcs outside the program segement [#1493](https://github.com/lambdaclass/cairo-vm/pull/14923)
* feat: Allow running instructions from pcs outside the program segement [#1493](https://github.com/lambdaclass/cairo-vm/pull/1493)

* BREAKING: Partially Revert `Optimize trace relocation #906` [#1492](https://github.com/lambdaclass/cairo-vm/pull/1492)

Expand Down

0 comments on commit db708e3

Please sign in to comment.