Skip to content

Commit

Permalink
Remove flamegraph from cargo deps (#1554)
Browse files Browse the repository at this point in the history
* Remove cargo-deps from make deps

* Restore Makefile

* Remove Flamegraph from cargo deps

* Comment lines
  • Loading branch information
pefontana authored Jan 15, 2024
1 parent ef0ee41 commit 8b9aabe
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ ifndef PROPTEST_CASES
endif

.PHONY: build-cairo-1-compiler build-cairo-1-compiler-macos build-cairo-2-compiler build-cairo-2-compiler-macos \
deps deps-macos cargo-deps build run check test clippy coverage benchmark flamegraph \
deps deps-macos cargo-deps build run check test clippy coverage benchmark \
compare_benchmarks_deps compare_benchmarks docs clean \
compare_vm_output compare_trace_memory compare_trace compare_memory \
compare_trace_memory_proof compare_all_proof compare_trace_proof compare_memory_proof compare_air_public_input \
Expand Down Expand Up @@ -183,7 +183,8 @@ build-cairo-2-compiler:
cargo-deps:
cargo install --version 0.3.1 iai-callgrind-runner
cargo install --version 1.1.0 cargo-criterion
cargo install --version 0.6.1 flamegraph
# Temporarily removed due to version issues. Installing cargo flamegraph pumps an error in rust 1.70
# cargo install --version 0.6.1 flamegraph
cargo install --version 1.14.0 hyperfine
cargo install --version 0.9.49 cargo-nextest
cargo install --version 0.5.9 cargo-llvm-cov
Expand Down Expand Up @@ -269,8 +270,9 @@ benchmark-action: cairo_bench_programs
iai-benchmark-action: cairo_bench_programs
cargo bench --bench iai_benchmark

flamegraph:
cargo flamegraph --root --bench criterion_benchmark -- --bench
# Temporarily removed due to version issues. Installing cargo flamegraph pumps an error in rust 1.70
# flamegraph:
# cargo flamegraph --root --bench criterion_benchmark -- --bench

compare_benchmarks: cairo_bench_programs
cd bench && ./run_benchmarks.sh
Expand Down

0 comments on commit 8b9aabe

Please sign in to comment.