-
Notifications
You must be signed in to change notification settings - Fork 164
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix: ignore missing null values when comparing PIEs
Problem: the new implementation of `CairoPie` using the `CairoPieAdditionalData` struct makes it hard to reproduce the exact same behaviour as `cairo-lang` when handling builtins with no data. While `cairo-lang` will generate a null value and include it in the JSON file, we can only (easily) generate a null value for each builtin or for none of them. Solution: make the comparator script more flexible by filtering out null values from JSON contents.
- Loading branch information
1 parent
fdb955b
commit 7773780
Showing
2 changed files
with
22 additions
and
2 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters