Move to download images using requests library. #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykaul
force-pushed
the
download_using_requests
branch
from
2fc5a9f to
b831a10
Compare
|
Is python-requests available on RHEL and Centos? this will be needed for lago demo tool and running lago on RHEL. |
|
@eedri I'd be very surprised if it's not, but apparently things are failing :( |
gbenhaim
reviewed
Mar 22, 2018
| @@ -15,3 +15,4 @@ wrapt | |||
| Jinja2 | |||
| xmltodict | |||
| netaddr | |||
| requests | |||
There was a problem hiding this comment.
It should be added to the spec file as well.
| import sys | ||
| import urllib |
More modern, hopefully somewhat faster.
mykaul
force-pushed
the
download_using_requests
branch
from
a0a5b2b to
c4e1107
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More modern, hopefully somewhat faster.