Improve secure middleware readability and add deprecation notice#2826
Closed
Improve secure middleware readability and add deprecation notice#2826
Conversation
- Refactor HSTS header construction using slice and strings.Join for better readability instead of nested fmt.Sprintf - Add deprecation notice for X-XSS-Protection header with CSP recommendation - Remove unused fmt import Improves code maintainability and provides better user guidance. Fixes #2799 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
aldas
requested changes
Sep 30, 2025
Contributor
aldas
left a comment
There was a problem hiding this comment.
I think all of these strings.Join(directives, "; ") calculation could be precalculated, between 109 and 110 lines
return func(next echo.HandlerFunc) echo.HandlerFunc {
// here
return func(c echo.Context) error {
Contributor
|
closing, v5 is out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves code readability and maintainability of the secure middleware with better user guidance.
Changes:
fmt.Sprintfwith slice building andstrings.Joinfor clearer logicfmtimportBenefits:
Test plan
Fixes #2799
🤖 Generated with Claude Code