Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add batchSignDataItem to Arconnect Strategy #24

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Add batchSignDataItem to Arconnect Strategy #24

merged 3 commits into from
Oct 10, 2024

Conversation

7i7o
Copy link
Contributor

@7i7o 7i7o commented Oct 9, 2024

This PR adds the batchSignDataItem api endpoint to the Arconnect Strategy

@7i7o 7i7o requested a review from nicholaswma October 9, 2024 18:57
nicholaswma
nicholaswma approved these changes Oct 9, 2024
View reviewed changes
Copy link

@nicholaswma nicholaswma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - not sure if it's necessary, but arconnect types library has been updated to 1.0.4

@7i7o
Copy link
Contributor Author

7i7o commented Oct 10, 2024

utACK - not sure if it's necessary, but arconnect types library has been updated to 1.0.4

Yes! 🙌
I'll update it later today so we avoid type errors

@7i7o 7i7o force-pushed the feat-batch-sign-dataitem branch from 4d562c3 to dca727c Compare October 10, 2024 11:44
@7i7o 7i7o merged commit 469e87f into kranthi/ensurePermissions Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholaswma nicholaswma nicholaswma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@7i7o @nicholaswma