Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BA-438): Libc version not parsed on image without metadata label #3341

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kyujin-cho
Copy link
Member

Follow-up PR of #3173 and #2582. On #3173 we forced Entrypoint value as sh to force override the value set from the image, but it caused another shell script evaluation error. Along with that it seems that we can just let container use docker system's default value by passing [""] as the Entrypoint config.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

@github-actions github-actions bot added comp:agent Related to Agent component size:XS ~10 LoC labels Jan 2, 2025
@kyujin-cho kyujin-cho changed the title fix: Libc version not parsed on image without metadata label fix(GF-115): Libc version not parsed on image without metadata label Jan 2, 2025
@kyujin-cho kyujin-cho added this to the 24.09 milestone Jan 2, 2025
@kyujin-cho kyujin-cho changed the title fix(GF-115): Libc version not parsed on image without metadata label fix(BA-438): Libc version not parsed on image without metadata label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:agent Related to Agent component size:XS ~10 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant