[FR-17] feat: update desired_session_count field name to replicas
#2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.03% (-0% 🔻) |
398/7916 |
| 🔴 | Branches | 4.35% (-0.02% 🔻) |
237/5445 |
| 🔴 | Functions | 3.02% (-0% 🔻) |
78/2586 |
| 🔴 | Lines | 4.94% (-0% 🔻) |
383/7748 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from d30759e
ironAiken2
changed the title
desired_session_count field name to replicasdesired_session_count field name to replicas
ironAiken2
force-pushed
the
feat/deprecated-session-routing-count
branch
from
ea9696c to
cc9297b
Compare
ironAiken2
force-pushed
the
feat/deprecated-session-routing-count
branch
3 times, most recently
from
70d4813 to
662efcf
Compare
ironAiken2
force-pushed
the
feat/deprecated-session-routing-count
branch
from
662efcf to
a8eabef
Compare
ironAiken2
force-pushed
the
feat/deprecated-session-routing-count
branch
from
a8eabef to
6451393
Compare
ironAiken2
force-pushed
the
feat/deprecated-session-routing-count
branch
from
6451393 to
d30759e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #2957 issue
Since Backend.AI Core version 24.12.0, the desired_session_count field has been replaced with
replicas.Changes:
replicasfield to service creation and update interfacesdesired_session_countfield for manager version >= 24.12.0desired_session_countandreplicasfields@deprecatedSinceand@sincedirectivesreplicasfeature flag check in client capabilitiesHow to test:
desired_session_countorreplicasis used when creating or modifying a service, depending on the manager version. (From 24.12.0 onwards, replicas is used.)