Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: fix broken tests due to NEO mainlayout, Agent select and Image parsing #2851

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Nov 14, 2024

Changes

  • In component:
    • Added Suspense wrapper around AgentSelect component (related to add: AgentSelect when hideAgent configuration is disabled #2599)
    • Added copy button functionality for environment image names in session launcher
    • Updated breadcrumb selectors in e2e tests to use data-testid attribute
    • Fixed resource limit column name casing in environment tests
  • In test code:
    • Added clipboard permission handling for copying image strings in config tests
    • Increased session creation timeout from 15s to 30s

Rationale:

  • Improves test reliability by using more stable selectors
  • Enhances user experience by adding copy functionality for image names
  • Prevents timeout issues during session creation in slower environments
  • Implements proper loading state handling for agent selection

Testing:
The following scenarios should be verified:

  1. Breadcrumb navigation and visibility in various pages
  2. Image name copying functionality in session launcher
  3. Session creation with extended timeout
  4. Agent selection with loading states
  5. Environment resource limit display and interaction

Copy link

graphite-app bot commented Nov 14, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

yomybaby commented Nov 14, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yomybaby yomybaby marked this pull request as ready for review November 14, 2024 04:13
@yomybaby yomybaby force-pushed the e2e/update-related-to-neo-mainlayout branch from a3a0007 to 06bd70c Compare November 14, 2024 05:37
@yomybaby yomybaby force-pushed the e2e/update-related-to-neo-mainlayout branch from 06bd70c to 74a0716 Compare November 14, 2024 06:34
@yomybaby yomybaby force-pushed the e2e/update-related-to-neo-mainlayout branch from 74a0716 to 1a0b89f Compare November 14, 2024 06:35
@yomybaby yomybaby force-pushed the e2e/update-related-to-neo-mainlayout branch from 1a0b89f to fcdadaa Compare November 15, 2024 03:36
@yomybaby yomybaby force-pushed the e2e/update-related-to-neo-mainlayout branch from fcdadaa to 73b9547 Compare November 15, 2024 03:38
@yomybaby yomybaby force-pushed the e2e/update-related-to-neo-mainlayout branch from 73b9547 to 64b2b0e Compare November 15, 2024 03:41
@yomybaby yomybaby force-pushed the e2e/update-related-to-neo-mainlayout branch from 64b2b0e to 4bc60ce Compare November 15, 2024 07:39
@yomybaby yomybaby changed the base branch from feature/neo-sider to feature/webui-neo-toggle-sider November 15, 2024 07:39
@yomybaby yomybaby force-pushed the feature/webui-neo-toggle-sider branch from 9f465cc to e79c472 Compare November 15, 2024 07:44
@yomybaby yomybaby force-pushed the e2e/update-related-to-neo-mainlayout branch from 4bc60ce to 5dcfde3 Compare November 15, 2024 07:44
@yomybaby yomybaby force-pushed the e2e/update-related-to-neo-mainlayout branch from fbe19d6 to f1e1314 Compare November 18, 2024 02:28
@yomybaby yomybaby force-pushed the feature/webui-neo-toggle-sider branch from 236b757 to 79dd60a Compare November 18, 2024 03:10
@yomybaby yomybaby force-pushed the e2e/update-related-to-neo-mainlayout branch 2 times, most recently from 22eda91 to 8648867 Compare November 18, 2024 03:13
@yomybaby yomybaby force-pushed the feature/webui-neo-toggle-sider branch from 79dd60a to 5423dc8 Compare November 18, 2024 03:25
@yomybaby yomybaby force-pushed the e2e/update-related-to-neo-mainlayout branch from 8648867 to 55704d4 Compare November 18, 2024 03:26
@yomybaby yomybaby force-pushed the feature/webui-neo-toggle-sider branch from 5423dc8 to 8e397a2 Compare November 18, 2024 03:34
@yomybaby yomybaby force-pushed the e2e/update-related-to-neo-mainlayout branch from 55704d4 to 5d3cca4 Compare November 18, 2024 03:34
@yomybaby yomybaby linked an issue Nov 18, 2024 that may be closed by this pull request
@ironAiken2 ironAiken2 force-pushed the feature/webui-neo-toggle-sider branch from 8e397a2 to e7e9878 Compare November 18, 2024 05:28
@ironAiken2 ironAiken2 force-pushed the e2e/update-related-to-neo-mainlayout branch from 5d3cca4 to d087f79 Compare November 18, 2024 05:28
@yomybaby yomybaby force-pushed the feature/webui-neo-toggle-sider branch from e7e9878 to 07b7970 Compare November 19, 2024 09:40
@yomybaby yomybaby force-pushed the e2e/update-related-to-neo-mainlayout branch from d087f79 to fa64aa7 Compare November 19, 2024 09:40
@yomybaby yomybaby force-pushed the feature/webui-neo-toggle-sider branch from 07b7970 to 4541f88 Compare November 20, 2024 06:53
@yomybaby yomybaby force-pushed the e2e/update-related-to-neo-mainlayout branch from fa64aa7 to f51403b Compare November 20, 2024 06:53
@yomybaby yomybaby changed the base branch from feature/webui-neo-toggle-sider to graphite-base/2851 November 20, 2024 06:58
@yomybaby yomybaby force-pushed the e2e/update-related-to-neo-mainlayout branch from f51403b to 89f16a0 Compare November 20, 2024 07:05
@yomybaby yomybaby changed the base branch from graphite-base/2851 to main November 20, 2024 07:06
@yomybaby yomybaby force-pushed the e2e/update-related-to-neo-mainlayout branch from 89f16a0 to 6678e6d Compare November 20, 2024 07:06
@yomybaby yomybaby force-pushed the e2e/update-related-to-neo-mainlayout branch from 6678e6d to f288411 Compare November 20, 2024 07:21
@github-actions github-actions bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Nov 20, 2024
Copy link

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 5.29% 395/7462
🔴 Branches
4.59% (-0% 🔻)
237/5165
🔴 Functions 3.16% 78/2466
🔴 Lines 5.21% 380/7295

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from f288411

@yomybaby yomybaby merged commit eb588e9 into main Nov 20, 2024
8 checks passed
@yomybaby yomybaby deleted the e2e/update-related-to-neo-mainlayout branch November 20, 2024 07:24
@yomybaby yomybaby mentioned this pull request Nov 26, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MainLayout NEO: Sider
1 participant