Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply session data #2753

Draft
wants to merge 10 commits into
base: feature/additional-pages
Choose a base branch
from

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Oct 16, 2024

Enhanced Session List and Start Page

This PR introduces improvements to the NeoSessionList component and StartPage:

NeoSessionList Enhancements:

  • Added new columns: index, name, status, utils, accelerator, CPU, RAM, and elapsed time
  • Improved rendering of AI Accelerator information using ResourceNumber component
  • Implemented real-time elapsed time display using BAIIntervalText component
  • Refined column definitions and data rendering
  • Enable sorting by allocating key.

StartPage Update:

  • Added null check for hostname in notification message

Screenshots:

image.png

Checklist:

  • Documentation update for new session list columns
  • Test cases to verify correct rendering of new columns
  • Verify real-time elapsed time updates correctly
  • Confirm AI Accelerator information displays accurately
  • Check StartPage notification displays correctly with/without hostname

ironAiken2 and others added 10 commits October 16, 2024 11:38
<!--
Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes,
and how it affects the users and other developers.
-->

**Checklist:** (if applicable)

- [ ] Mention to the original issue
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
Copy link
Contributor Author

agatha197 commented Oct 16, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @agatha197 and the rest of your teammates on Graphite Graphite

Copy link

graphite-app bot commented Oct 16, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@agatha197 agatha197 mentioned this pull request Oct 16, 2024
6 tasks
@github-actions github-actions bot added the size:M 30~100 LoC label Oct 16, 2024
@lizable lizable force-pushed the feature/additional-pages branch from b4bad6a to d8dae9e Compare November 5, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants