util/agentwrapper: Implement _labgrid-agent #1791
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This hasn't been tested yet, but is a mere discussion point.
The thesis: On a host where labgrid has been installed and the exporter is supposed to run
we already have all the dependencies installed (at least in an environment, not necessarily an isolated one).
This means it should not only not be necessary to copy over the agent file, as its already present on the exporter host,
but not necessary to install dependencies globally on it either.
This introduces a new command
_labgrid-agent, which due to the leading underscore should not confuse users using autocompletion.Considerations
The approach has a considered drawback:
Currently the client uses the
agentwrapperand theagents/shipped with the client matching its version perfectly.With this change it would only use the latter and potential upcoming incompatibilities in the wrapper could show up, in case somebody installed different versions of labgrid on the client- and the exporterhost.
I think the risk is low though, as the wrapper does not change much anymore and a version check could be introduced, once its behaviour is changed in a breaking way.
Checklist
Add a section on how to use the feature to doc/usage.rstFixes #1790