Merge pull request dotnet#1179 from MattFromRVA/Improve_VerifyCodeFix…

…Async_Exception_Message Improve exception message for VerifyCodeFixAsync
kzu · Aug 26, 2024 · bc8a063 · bc8a063
2 parents 0af0fc3 + e401620
commit bc8a063
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 6 deletions.
diff --git a/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.CodeFix.Testing/CodeFixTest`1.cs b/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.CodeFix.Testing/CodeFixTest`1.cs
@@ -692,7 +692,11 @@ private async Task VerifyProjectAsync(ProjectState newState, Project project, IV
 
             try
             {
-                if (expectedNumberOfIterations >= 0)
+                if (expectedNumberOfIterations == 0)
+                {
+                    verifier.Equal(expectedNumberOfIterations, expectedNumberOfIterations - numberOfIterations, "No code fixes were expected, but a fix was offered that made no changes to the code.");
+                }
+                else if (expectedNumberOfIterations > 0)
                 {
                     verifier.Equal(expectedNumberOfIterations, expectedNumberOfIterations - numberOfIterations, $"Expected '{expectedNumberOfIterations}' iterations but found '{expectedNumberOfIterations - numberOfIterations}' iterations.");
                 }
@@ -862,7 +866,11 @@ private async Task VerifyProjectAsync(ProjectState newState, Project project, IV
 
             try
             {
-                if (expectedNumberOfIterations >= 0)
+                if (expectedNumberOfIterations == 0)
+                {
+                    verifier.Equal(expectedNumberOfIterations, expectedNumberOfIterations - numberOfIterations, "No code fixes were expected, but a fix was offered that made no changes to the code.");
+                }
+                else if (expectedNumberOfIterations > 0)
                 {
                     verifier.Equal(expectedNumberOfIterations, expectedNumberOfIterations - numberOfIterations, $"Expected '{expectedNumberOfIterations}' iterations but found '{expectedNumberOfIterations - numberOfIterations}' iterations.");
                 }

diff --git a/...sis.Testing/Microsoft.CodeAnalysis.CodeFix.Testing.UnitTests/MissingCodeFixMarkupTests.cs b/...sis.Testing/Microsoft.CodeAnalysis.CodeFix.Testing.UnitTests/MissingCodeFixMarkupTests.cs
@@ -78,7 +78,7 @@ namespace MyNamespace {|Brace:{|}
             Assert.Equal(
                 """
                 Context: Iterative code fix application
-                Expected '0' iterations but found '1' iterations.
+                No code fixes were expected, but a fix was offered that made no changes to the code.
                 """.ReplaceLineEndings(),
                 exception.Message);
 
@@ -91,7 +91,7 @@ namespace MyNamespace {|Brace:{|}
             Assert.Equal(
                 """
                 Context: Iterative code fix application
-                Expected '0' iterations but found '1' iterations.
+                No code fixes were expected, but a fix was offered that made no changes to the code.
                 """.ReplaceLineEndings(),
                 exception.Message);
         }

diff --git a/...eAnalysis.Testing/Microsoft.CodeAnalysis.CodeFix.Testing.UnitTests/MissingCodeFixTests.cs b/...eAnalysis.Testing/Microsoft.CodeAnalysis.CodeFix.Testing.UnitTests/MissingCodeFixTests.cs
@@ -82,7 +82,7 @@ namespace MyNamespace {
             Assert.Equal(
                 """
                 Context: Iterative code fix application
-                Expected '0' iterations but found '1' iterations.
+                No code fixes were expected, but a fix was offered that made no changes to the code.
                 """.ReplaceLineEndings(),
                 exception.Message);
 
@@ -95,7 +95,7 @@ namespace MyNamespace {
             Assert.Equal(
                 """
                 Context: Iterative code fix application
-                Expected '0' iterations but found '1' iterations.
+                No code fixes were expected, but a fix was offered that made no changes to the code.
                 """.ReplaceLineEndings(),
                 exception.Message);
         }