Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default tag groupings #55

Open
wants to merge 3 commits into
base: 1.19
Choose a base branch
from

Conversation

nskobelevs
Copy link

Summary

Adds a list of tags (currently ore tags) that will be grouped by default

Motivation

During my usage of the mod I noticed stone ores and their deepslate variants weren't grouped together. This was annoying when mining in areas where both exist in the same ore veins so I made this change to use the forked version personally but it might benefit the mod itself.

I see all tags were grouped together previously (comment in ExcavateHelper.isTheSameBlock) and while true this is a bit too much, I think it does make sense to group certain tags together.

Testing

Tested in game to make sure the functionality works and that the config option is respected

Open Questions

  • Translations: Unfortunately I do not know Portuguese nor Chinese so only English translation for the button exists.
  • Should other tags be included? Maybe logs / planks?

@kyrptonaught
Copy link
Owner

This is a good addition, thank you.

Though I could see some benefit to being able to manually enabled/disable these and add/delete them. I'm thinking this might be useful to pack makers.

@nskobelevs
Copy link
Author

By "manually" do you mean by the player or by a pack maker using a pre-made config file?
At the moment a player can disable all of them but not edit them individually.

Could just add the default tags to groups and enable custom groups by default? Allows the modification as well as being clear to the player on what tags are grouped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants