-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ライバルスキル比較機能 #30
Open
ynq-otoge
wants to merge
14
commits into
kumamotone:master
Choose a base branch
from
ynq-otoge:compare_skill
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ライバルスキル比較機能 #30
+284
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
全角文字の場合に幅が足りない場合があったため
# Conflicts: # app/assets/javascripts/pxgradient-1.0.3.js # app/controllers/users_controller.rb # app/views/skills/new.html.erb # app/views/users/_sptable.html.erb # app/views/users/drum.html.erb # app/views/users/guitar.html.erb
ライバル比較機能追加で片方にしかスキルがない曲の表記が必要になったため
スマホで閲覧可能なように列数を削減
とってもとっても、ありがとうございます! 軽くみて気になったのは、
の2点ですが、実際に動かしてみて確認してみたいので、詳細についてはちょっとお待ちいただけると‥! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更内容(概要)
Issue #29 に対応するPullReqです。
スキル表(users/[id]/[guitar|drum])画面で別のユーザとスキルを比較する機能を実装しました。
スマホ画面(幅320px)とPC画面での見た目は下図のようになります。
変更内容(ソースコード)
難易度表記(EXTとかMASとか)に無効値の表記を追加