docs: CheckBox の Story を見直し #5031
Open
+106
−353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-sasaki-0529
commented
Oct 18, 2024
| checked: true, | ||
| mixed: true, | ||
| }, | ||
| } |
There was a problem hiding this comment.
mixed は checked ありきなので、ここだけ input 要素の props を指定しちゃってます。
commit: |
s-sasaki-0529
commented
Oct 18, 2024
| const mixed = [true, false] | ||
| const error = [true, false] | ||
| const disabled = [true, false] | ||
| const checked = [true, false] |
There was a problem hiding this comment.
disabled / checked は Input 側の props だけど見た目に大きく影響を与えるので網羅します。
s-sasaki-0529
requested review from
AtsushiM and
atzzCokeK
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
#4949 の方針に沿って、Checkbox の Story を見直しました。
(優先度的には Table が先だけど、 TdCheckbox とか含まれるから先に Checkbox やったほうが良さそうと判断)
変更内容
確認方法
Storybook や Chromatic で確認してください。