Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: WakuWakuButton を追加 #5018

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: WakuWakuButton を追加 #5018

wants to merge 3 commits into from

Conversation

uknmr
Copy link
Contributor

@uknmr uknmr commented Oct 16, 2024

関連URL

https://smarthr.atlassian.net/browse/SHRUI-986

概要

BulkActionRow のわくわくチェックの操作ボタンとして WakuWakuButton を追加しました。BulkActionRow の上に置いてもコントラスト比が保てるように link-darker を作っています。

変更内容

  • preset 内の link color を整理
  • WakuWakuButton を作成
  • Table の Story にわくわくチェックのサンプルを追加

確認方法

Storybook や Chromatic で確認してください。

@uknmr uknmr requested a review from a team as a code owner October 16, 2024 06:28
@uknmr uknmr requested review from misako0927 and nabeliwo and removed request for a team October 16, 2024 06:28
Copy link

pkg-pr-new bot commented Oct 16, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/kufu/smarthr-ui@5018

commit: 1d70e40

@uknmr uknmr changed the title feat: Button の variant に tertiary を追加 feat: WakuWakuButton を追加 Oct 17, 2024
@@ -6,3 +6,4 @@ export { TdCheckbox } from './TdCheckbox'
export { BulkActionRow } from './BulkActionRow'
export { EmptyTableBody } from './EmptyTableBody'
export { TableReel } from './TableReel'
export { WakuWakuButton } from './WakuWakuButton'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一応単体で利用できるコンポーネントということになるので、RSC対応チェックの方に追加してもらえると助かります!(ベースが Button なので多分クライアントコンポーネント)

/**
* サーバーコンポーネントでは利用できないコンポーネント一覧(アルファベット順)
*/
const CLIENT_COMPONENTS = [
'AccordionPanel',
'AccordionPanelContent',
'AccordionPanelItem',
'AccordionPanelTrigger',
'ActionDialog',
'ActionDialogContent',
'ActionDialogWithTrigger',
'AppLauncher',
'AppNavi',
'AppNaviDropdown',
'AppNaviDropdownMenuButton',
'Article',
'Aside',
'Base',
'BaseColumn',
'BottomFixedArea',
'BulkActionRow',
'Button',
'Calendar',
'Center',
'CheckBox',
'Cluster',
'CompactInformationPanel',
'CurrencyInput',
'DatePicker',
'DefinitionList',
'Dialog',
'DialogCloser',
'DialogContent',
'DialogTrigger',
'DialogWrapper',
'DropZone',
'Dropdown',
'DropdownCloser',
'DropdownContent',
'DropdownMenuButton',
'DropdownTrigger',
'EmptyTableBody',
'ErrorScreen',
'Fieldset',
'FilterDropdown',
'FlashMessage',
'FloatArea',
'FormControl',
'FormDialog',
'FormDialogContent',
'Header',
'HeaderDropdownMenuButton',
'Heading',
'InformationPanel',
'InputFile',
'LanguageSwitcher',
'LineClamp',
'MessageDialog',
'MessageDialogContent',
'MessageScreen',
'ModelessDialog',
'MultiComboBox',
'Nav',
'NotificationBar',
'PageCounter',
'PageHeading',
'Pagination',
'RadioButton',
'RadioButtonPanel',
'Reel',
'RemoteDialogTrigger',
'RemoteTriggerActionDialog',
'RemoteTriggerFormDialog',
'RemoteTriggerMessageDialog',
'SearchInput',
'Section',
'SegmentedControl',
'Select',
'SideNav',
'Sidebar',
'SingleComboBox',
'SortDropdown',
'Stack',
'Stepper',
'Switch',
'TabBar',
'TabItem',
'TableReel',
'TdCheckbox',
'Textarea',
'ThCheckbox',
'Tooltip',
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants