Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split "testing policies" section #26

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Split "testing policies" section #26

merged 2 commits into from
Apr 19, 2021

Conversation

flavio
Copy link
Member

@flavio flavio commented Apr 16, 2021

Split the testing document into two dedicated chapters.

Also, shuffle the topics around inside of the SUMMARY

This fixes #21

@flavio flavio requested a review from ereslibre April 16, 2021 12:46
Split the testing document into two dedicated chapters.

Also, shuffle the topics around inside of the SUMMARY

This fixes #21
Copy link
Member

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of comments.

your code behaves the way you expect.
* As an end user: you found a Kubewarden Policy and you want to tune/test the policy
settings before deploying it, maybe you want to keep testing these settings
inside of your CI/CD pipelines,...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ,... intended?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, there could be more usages we can't even imagine right now

src/testing-policies/03-cluster-operators.md Outdated Show resolved Hide resolved
Point to the actively maintained repo
@flavio
Copy link
Member Author

flavio commented Apr 19, 2021

I've updated all the links to the bat project. If you are fine with that we can go ahead and merge this PR

@ereslibre ereslibre merged commit e916e66 into main Apr 19, 2021
@ereslibre ereslibre deleted the doc-structure branch April 19, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation structure
2 participants