-
Notifications
You must be signed in to change notification settings - Fork 305
build: use gzip compression on pkg_tar #3999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f9fd468 to
e0ec034
Compare
|
/cc @akalenyu |
|
fyi, might need this in kv/kv as well... |
|
really nice find on this one! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akalenyu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Failures happen due to the archive repacking. |
|
/hold |
Before the transition from rules_docker to rules_oci resulting container image sizes were around 1/4th what they are now. This is because rules_docker used gzip compression implicitly[1]. This commit explicitly uses gzip compression for all pkg_tar directives and also compresses the rpm bases generated by bazeldnf to restore the resulting images to their original sizes. [1] https://github.com/bazelbuild/rules_docker/blob/master/docs/container.md#container_image Signed-off-by: Adi Aloni <aaloni@redhat.com>
e0ec034 to
ee06ce1
Compare
|
Unholding for now, if rmohr/bazeldnf#170 ever makes it in, we'll use it as well for rpm compression. /unhold |
|
/retest |
/lgtm |
|
/test pull-containerized-data-importer-e2e-nfs |
What this PR does / why we need it:
Before the transition from rules_docker to rules_oci resulting container image sizes were around 1/3rd what they are now. This is because rules_docker used gzip compression implicitly[1].
This PR explicitly uses gzip compression for all pkg_tar directives in order to restore the resulting images to their original sizes.
[1] https://github.com/bazelbuild/rules_docker/blob/master/docs/container.md#container_image
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: