Add presigned download url #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ondra Machacek <[email protected]>
|
Can one of the admins verify this patch? |
tupyy
reviewed
Feb 5, 2025
api/v1alpha1/openapi.yaml
Outdated
| @@ -189,6 +189,51 @@ paths: | |||
| application/json: | |||
| schema: | |||
| $ref: '#/components/schemas/Error' | |||
| /api/v1/image/{id}/image-url: | |||
There was a problem hiding this comment.
as per what we've discussed this will be under source:
maybe api/v1/source/{id}/image-url
tupyy
reviewed
Feb 5, 2025
api/v1alpha1/agent/openapi.yaml
Outdated
| @@ -8,6 +8,51 @@ info: | |||
| servers: | |||
| - url: / | |||
| paths: | |||
| /api/v1/image/bytoken/{token}: | |||
There was a problem hiding this comment.
this api is protected. How do you intend to pass the authentication with a curl?
There was a problem hiding this comment.
it will be forwarded via cloud.rh.com/....
This commit changes the model from multi-source to single-source (i.e one source - one agent). Signed-off-by: Cosmin Tupangiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On hold until we are back on single source model.