Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check claimName on DV status #541

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Check claimName on DV status #541

merged 1 commit into from
Aug 15, 2023

Conversation

bennyz
Copy link
Member

@bennyz bennyz commented Aug 15, 2023

@bennyz
Check claimName on DV status
55cd900 
It seems like dv.PVC is always nil because we don't create a DV from a
PVC, this leads to failing to find the DV whenever the importer pod
fails and it will restart forever instead of 3 times

Signed-off-by: Benny Zlotnik <[email protected]>

rename DataVolume to DataVolumeWrapper

Make it slightly less confusing

Signed-off-by: Benny Zlotnik <[email protected]>
@bennyz bennyz requested a review from ahadas as a code owner August 15, 2023 12:19
@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ahadas ahadas merged commit 91f7934 into kubev2v:release-v2.5.0 Aug 15, 2023
@bennyz bennyz deleted the backport-cdi-retry branch October 2, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahadas ahadas ahadas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bennyz @ahadas