Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ova ProductSection to ova provider server resp #1204

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arturshadnik
Copy link
Contributor

@arturshadnik arturshadnik commented Nov 20, 2024

This PR extends the Inventory service and OVA provider server to also return the ProductSection as part of the VM payload. ProductSection can contain user configurable fields that need to be set in order for the VM to run properly. Only the relevant subset of the original ProductSection is added.

Example response:

"product": {
        "Property": [
            {
                "Key": "va-ssh-public-key",
                "Type": "string",
                "Qualifiers": null,
                "UserConfigurable": true,
                "Default": null,
                "Password": null,
                "Label": "Set the SSH public key allowed to access the appliance",
                "Description": "This will enable the SSHD service and configure the specified public key for the user 'bitnami'",
                "Values": null
            },
            {
                "Key": "user-data",
                "Type": "string",
                "Qualifiers": null,
                "UserConfigurable": true,
                "Default": null,
                "Password": null,
                "Label": "User data to be made available inside the instance",
                "Description": "This allows to pass any text to the appliance. It will be executed if it starts with a shebang (\"#!\"). The value should be encoded in base64",
                "Values": null
            }
        ]
    }

@arturshadnik arturshadnik marked this pull request as draft November 26, 2024 19:44
Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Generally looks good at first glance. But what is the usage? Or why do we need to start collecting it? I'm not against it just wonder what is the root issue

@arturshadnik
Copy link
Contributor Author

Thanks for the feedback @mnecas, this is one part of a change to allow configuring ovf-env during OVA migration. I will open an issue with more detail and to track all required changes.

@arturshadnik
Copy link
Contributor Author

Thanks for the feedback @mnecas, this is one part of a change to allow configuring ovf-env during OVA migration. I will open an issue with more detail and to track all required changes.

Created an issue here #1216, let me know your thoughts.

@arturshadnik arturshadnik force-pushed the feat/ova-product branch 2 times, most recently from 959fb1f to 1942a8c Compare November 27, 2024 22:40
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 15.67%. Comparing base (4d6a3f1) to head (1945072).

Files with missing lines Patch % Lines
cmd/ova-provider-server/ova-provider-server.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1204      +/-   ##
==========================================
+ Coverage   15.63%   15.67%   +0.04%     
==========================================
  Files         112      112              
  Lines       23107    23108       +1     
==========================================
+ Hits         3612     3623      +11     
+ Misses      19210    19198      -12     
- Partials      285      287       +2     
Flag Coverage Δ
unittests 15.67% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 28, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants