-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ova ProductSection to ova provider server resp #1204
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Generally looks good at first glance. But what is the usage? Or why do we need to start collecting it? I'm not against it just wonder what is the root issue
Thanks for the feedback @mnecas, this is one part of a change to allow configuring |
959fb1f
to
1942a8c
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1204 +/- ##
==========================================
+ Coverage 15.63% 15.67% +0.04%
==========================================
Files 112 112
Lines 23107 23108 +1
==========================================
+ Hits 3612 3623 +11
+ Misses 19210 19198 -12
- Partials 285 287 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Artur Shad Nik <[email protected]>
1942a8c
to
1945072
Compare
Quality Gate passedIssues Measures |
This PR extends the Inventory service and OVA provider server to also return the ProductSection as part of the VM payload. ProductSection can contain user configurable fields that need to be set in order for the VM to run properly. Only the relevant subset of the original ProductSection is added.
Example response: