MTV-1041 | Change created virt-v2v conversion output to -o kubeVirt

[mnecas]

Issue:
We need to provide the firmware for the OVA and right now the firmware is not exposed from virt-v2v -o local but is available in the -o kubevirt.

Fix:
Change the output file of the virt-v2v to the -o kubevirt and expose that via the server to the controller.

Notes:
In future, we could use also virt-v2v-inspector to expose this parameter https://issues.redhat.com/browse/RHEL-58047. But right now not available in the rhel 9.4 and as we have this parameter in the -o kubevirt I don't think that we need to backport it.
This is continuation of: #778

[yaacov]

LGTM, is this part of #778 ?

[mnecas]

yeah I just rebased it and I'll add some additional commits in followup MRs

[codecov]

Codecov Report

Attention: Patch coverage is 1.62602% with 121 lines in your changes missing coverage. Please review.

Project coverage is 16.42%. Comparing base (d5bce55) to head (0f5ab69).

Files with missing lines	Patch %	Lines
virt-v2v/yaml-reader.go	0.00%	36 Missing ⚠️
virt-v2v/entrypoint.go	5.55%	31 Missing and 3 partials ⚠️
pkg/controller/plan/util/kubevirtvmparser.go	0.00%	32 Missing ⚠️
pkg/controller/plan/kubevirt.go	0.00%	14 Missing ⚠️
pkg/controller/plan/migration.go	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1020      +/-   ##
==========================================
- Coverage   16.44%   16.42%   -0.02%     
==========================================
  Files         107      107              
  Lines       19645    19672      +27     
==========================================
+ Hits         3230     3232       +2     
- Misses      16127    16149      +22     
- Partials      288      291       +3     

Flag	Coverage Δ
unittests	16.42% <1.62%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 23.40426% with 36 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@650d73d). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/controller/plan/kubevirt.go	0.00%	15 Missing ⚠️
pkg/controller/plan/migration.go	0.00%	6 Missing ⚠️
pkg/controller/plan/util/kubevirtvmparser.go	62.50%	4 Missing and 2 partials ⚠️
virt-v2v/pkg/utils/command.go	0.00%	6 Missing ⚠️
virt-v2v/cmd/entrypoint.go	33.33%	1 Missing and 1 partial ⚠️
virt-v2v/pkg/utils/xml-reader.go	0.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1020   +/-   ##
=======================================
  Coverage        ?   16.28%           
=======================================
  Files           ?      112           
  Lines           ?    19772           
  Branches        ?        0           
=======================================
  Hits            ?     3220           
  Misses          ?    16268           
  Partials        ?      284           

Flag	Coverage Δ
unittests	16.28% <23.40%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[yaacov]

LGTM