Skip to content

Commit

Permalink
minor changes for -o yaml support
Browse files Browse the repository at this point in the history
Signed-off-by: Bella Khizgiyaev <bkhizgiy@redhat.com>
  • Loading branch information
bkhizgiy committed Aug 20, 2024
1 parent e94eae1 commit 8c38ec3
Showing 4 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
@@ -377,12 +377,12 @@ spec:
The VM Namespace
Only relevant for an openshift source.
type: string
operatingSystem:
description: The Operating System detected by virt-v2v.
type: string
newName:
description: The new name of the VM after matching DNS1123 requirements.
type: string
operatingSystem:
description: The Operating System detected by virt-v2v.
type: string
phase:
description: Phase
type: string
6 changes: 3 additions & 3 deletions operator/config/crd/bases/forklift.konveyor.io_plans.yaml
Original file line number Diff line number Diff line change
@@ -888,13 +888,13 @@ spec:
The VM Namespace
Only relevant for an openshift source.
type: string
operatingSystem:
description: The Operating System detected by virt-v2v.
type: string
newName:
description: The new name of the VM after matching DNS1123
requirements.
type: string
operatingSystem:
description: The Operating System detected by virt-v2v.
type: string
phase:
description: Phase
type: string
2 changes: 1 addition & 1 deletion pkg/controller/plan/kubevirt.go
Original file line number Diff line number Diff line change
@@ -969,7 +969,7 @@ func (r *KubeVirt) UpdateVmByConvertedConfig(vm *plan.VMStatus, pod *core.Pod, s
return
}
r.Log.Info("Setting the vm firmware ", vm.Firmware, "vmId", vm.ID)

Check warning on line 971 in pkg/controller/plan/kubevirt.go

Codecov / codecov/patch

pkg/controller/plan/kubevirt.go#L971

Added line #L971 was not covered by tests
case api.VSphere:

if vm.OperatingSystem, err = util.GetOperationSystemFromYaml(vmConf); err != nil {

Check warning on line 973 in pkg/controller/plan/kubevirt.go

Codecov / codecov/patch

pkg/controller/plan/kubevirt.go#L973

Added line #L973 was not covered by tests
err = liberr.Wrap(err)
return
2 changes: 1 addition & 1 deletion pkg/controller/plan/util/kubevirtvmparser.go
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@ import (

const (
// Name.
Name = "virt-v2v-parser"
Name = "kubevirt-vm-parser"
)

// Package logger.

0 comments on commit 8c38ec3

Please sign in to comment.