MTV-1719: Selecting a migration network for a CNV destination provider #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sgratch Please review this PR. It corrects incorrect information in the documentation. |
anarnold97
reviewed
Dec 11, 2024
documentation/modules/selecting-migration-network-for-virt-provider.adoc
Outdated
Show resolved
Hide resolved
|
@anarnold97 I made the change you suggested, but the line spacing looks off to me. It might be a template issue. What do you think? |
RichardHoch
force-pushed
the
cnv_dest_provider_mig_network
branch
3 times, most recently
from
f2dd6fd to
6d032dd
Compare
anarnold97
reviewed
Dec 15, 2024
documentation/modules/about-hook-crs-for-migration-plans-api.adoc
Outdated
Show resolved
Hide resolved
anarnold97
reviewed
Dec 15, 2024
documentation/modules/about-hook-crs-for-migration-plans-api.adoc
Outdated
Show resolved
Hide resolved
anarnold97
reviewed
Dec 15, 2024
documentation/modules/about-hook-crs-for-migration-plans-api.adoc
Outdated
Show resolved
Hide resolved
anarnold97
reviewed
Dec 15, 2024
documentation/modules/about-hook-crs-for-migration-plans-api.adoc
Outdated
Show resolved
Hide resolved
anarnold97
reviewed
Dec 15, 2024
| [id="adding-migration-hook_{context}"] | ||
| = Adding a migration hook to a migration plan | ||
|
|
||
| You can a migration hook to an existing migration plan. Although you can complete part of the procedure for adding the hook to migration plan by using either the CLI or UI, one step must be done using the CLi. |
There was a problem hiding this comment.
Suggested change
| You can a migration hook to an existing migration plan. Although you can complete part of the procedure for adding the hook to migration plan by using either the CLI or UI, one step must be done using the CLi. | |
| You can add a migration hook to an existing migration plan. Although, you can complete part of the procedure for adding the hook to a migration plan by using either the CLI or UI. However, one step must always be completed using the CLI. |
Bit of mess. LOL
anarnold97
reviewed
Dec 15, 2024
| * Migration plan | ||
| * Migration hook image or file (discuss) | ||
| * File containing the `Secret` for the source provider | ||
| * {ocp} service account that has at least Write-access permission for the namespace you are working in |
There was a problem hiding this comment.
Suggested change
| * {ocp} service account that has at least Write-access permission for the namespace you are working in | |
| * {ocp} service account that has at least *write access* permission for the namespace you are working in |
Looking at vmware-prerequisites.adoc, you have previously used write access. Then go with italics or bold
anarnold97
reviewed
Dec 15, 2024
| ... Paste your hook in *Ansible playbook*. | ||
| ... For a post-migration hook, follow the same steps in the *Post migration hook* section. | ||
| ... At the top of the tab, click *Update hooks*. | ||
| ... In a terminal, enter following command: |
There was a problem hiding this comment.
Suggested change
| ... In a terminal, enter following command: | |
| ... In a terminal, enter the following command: |
anarnold97
requested changes
Dec 15, 2024
Signed-off-by: RichardHoch <[email protected]> This reverts commit b7938b9.
RichardHoch
force-pushed
the
cnv_dest_provider_mig_network
branch
from
b60a1ea to
a046a74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTV 2.7
Resolves https://issues.redhat.com/browse/MTV-1719 by correcting the procedure in https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/2.7/html/installing_and_using_the_migration_toolkit_for_virtualization/migrating-vms-web-console_mtv#selecting-migration-network-for-virt-provider_mtv
Preview: https://file.corp.redhat.com/rhoch/cnv_dest_provider_mig_network/html-single/#adding-destination-providers [Section 4.2.2.2, "Selecting a migration network for an OpenShift Virtualization provider"]