Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry #584

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Telemetry #584

wants to merge 2 commits into from

Conversation

RichardHoch
Copy link
Collaborator

@nunzy1
Copy link

nunzy1 commented Nov 11, 2024

Hi Richard. Just a few comments.

The preview doesn’t seem to agree with the file changes. Also, this shows up in the preview:

"the following MTV usage data to improve the product: Data Data Data" or do we want to continue not mentioning it in customer-facing MTV documentation?
point out the data is anonymous and only used to make the product better and "proactive"."

For the bulleted points, I might do something like the following. (Please check our standards though.)

  • Status: The number of migrations. Includes those that failed, succeeded, or were canceled.
  • Provider: The number of migrations per provider. Includes Red Hat Virtualization, vSphere, OpenStack, OVA, and OpenShift Virtualization providers.
  • Mode: The number of migrations by mode. Includes both cold and warm migrations.
  • Target: The number of migrations by target. Includes targets that are local or remote.
  • Plan ID

I might shorten the sentence that follows:

Metrics are calculated every 10 seconds, and are reported per week, per month, and per year.

One note on “Plan ID” – I don’t see this mentioned anywhere else. Is it completely obvious what it is? If so, ok. If not, can we say give some sort of description?

@RichardHoch
Copy link
Collaborator Author

Thanks, @nunzy1 ! I made the changes you suggested.

@RichardHoch
Copy link
Collaborator Author

@mnecas Please review this PR.

@RichardHoch RichardHoch requested a review from mnecas November 12, 2024 17:02
Copy link
Contributor

@fabiand fabiand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@RichardHoch RichardHoch requested a review from jschuler December 15, 2024 08:34
@RichardHoch
Copy link
Collaborator Author

@jschuler Please review this PR. Thanks.

Copy link
Contributor

@fabiand fabiand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants