Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported migration network for MTV #578

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

RichardHoch
Copy link
Collaborator

@RichardHoch RichardHoch commented Oct 28, 2024

MTV 2.8.0

Resolves https://issues.redhat.com/browse/MTV-607 by adding notes and additions to procedures about supported migration networks for MTV.

Previews:

@RichardHoch RichardHoch marked this pull request as ready for review October 28, 2024 17:40
include::snip-mtu-value.adoc[]

// Is this still accurate?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgratch Although it's not part of the Jira -- could you also check this procedure? I could not get hold of a QE environment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still feasible but instead of setting it via the menu next to the provider, it's done via the plan.

Go to plans-> plan details tab -> settings section. And edit the Transfer Network field:
Screenshot from 2024-10-29 23-49-22

Click edit on the pencil next to this field for openning the popup:
Screenshot from 2024-10-29 23-50-01

Copy link

@nunzy1 nunzy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd change the sentence (I know you didn't introduce this sentence):

"If the conversion fails because the boot device provided is incorrect, it is possible to get the correct information by looking at the conversion pod logs."

To:

If the conversation fails because the boot device is incorrect, review the conversation pod logs for the correct information.

I'd change this sentence:

"If use any value of MTU besides the default value in your migration network, you must also use the same value in the [ocp-short] transfer network that you use."

To:

If you use any value of MTU besides the default value in your migration network, you must use the same value in the corresponding [ocp-short] transfer network.

@RichardHoch RichardHoch force-pushed the supp_mig_network branch 3 times, most recently from 12535fe to 0d5d145 Compare October 29, 2024 11:53
Signed-off-by: RichardHoch <[email protected]>
@RichardHoch
Copy link
Collaborator Author

@nunzy1 @anarnold97 Thanks for the reviews. I've made the changes you've suggested. Please review it again.

For the time being, I have left the file creating-migration-plan-2-6-3.adoc in the repo, although it is no longer called. I plan on removing it after SME and QE review of this PR, unless you suggest otherwise. It's replaced by creating-migration-plan-2-7.adoc in this PR.

@RichardHoch
Copy link
Collaborator Author

@sgratch I made the changes you suggested. Please review this PR again. Thanks.

@RichardHoch RichardHoch requested a review from sgratch October 30, 2024 12:54
. In the *Settings* section, click the Edit icon next to the *Transfer network*.
+
The *Edit migration plan transfer network* window opens.
. Select a network from the list of available networks and click *Save*.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants