Update ovier url help text #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaacov
added
the
kind/cleanup
Signed-off-by: yzamir <[email protected]>
yaacov
force-pushed
the
update-ovier-url-help-text
branch
from
92fbae1 to
16fcac6
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
sgratch
added a commit
to sgratch/forklift-console-plugin
that referenced
this pull request
Oct 1, 2023
As a followup for kubev2v#732, fix the oVirt provider's URL help text as follows: 1. Rephrase the error, warning and successful/initial text messages to be aligned with the documnetation, other providers fields and Patternfly error msg recommendations. 2. Set a url input ended with a "/" (i.e. "ovirt-engine/api/") as a valid url since it's mentioned on docs as valid and it's a common used case. 3. Fix a bug in which the waring text message string (helperTextMsgs.warning) is never displayed in the UI (the color is set to yellow to indicate the warning field validation state, but the text message was not changed accordingly). Signed-off-by: Sharon Gratch <[email protected]>
sgratch
added a commit
to sgratch/forklift-console-plugin
that referenced
this pull request
Oct 1, 2023
As a followup for kubev2v#732, fix the oVirt provider's URL help text as follows: 1. Rephrase the error, warning and successful/initial text messages to be aligned with the documnetation, other providers fields and Patternfly error msg recommendations. 2. Set a url input ended with a "/" (i.e. "ovirt-engine/api/") as a valid url since it's mentioned on docs as valid and it's a common used case. 3. Fix a bug in which the waring text message string (helperTextMsgs.warning) is never displayed in the UI (the color is set to yellow to indicate the warning field validation state, but the text message was not changed accordingly). Signed-off-by: Sharon Gratch <[email protected]>
sgratch
added a commit
to sgratch/forklift-console-plugin
that referenced
this pull request
Oct 3, 2023
As a followup for kubev2v#732, fix the oVirt provider's URL help text as follows: 1. Rephrase the error, warning and successful/initial text messages to be aligned with the documnetation, other providers fields and Patternfly error msg recommendations. 2. Set a url input ended with a "/" (i.e. "ovirt-engine/api/") as a valid url since it's mentioned on docs as valid and it's a common used case. 3. Fix a bug in which the waring text message string (helperTextMsgs.warning) is never displayed in the UI (the color is set to yellow to indicate the warning field validation state, but the text message was not changed accordingly). Signed-off-by: Sharon Gratch <[email protected]>
sgratch
added a commit
to sgratch/forklift-console-plugin
that referenced
this pull request
Oct 3, 2023
As a followup for kubev2v#732, fix the oVirt provider's URL help text as follows: 1. Rephrase the error, warning and successful/initial text messages to be aligned with the documnetation, other providers fields and Patternfly error msg recommendations. 2. Set a url input ended with a "/" (i.e. "ovirt-engine/api/") as a valid url since it's mentioned on docs as valid and it's a common used case. 3. Fix a bug in which the waring text message string (helperTextMsgs.warning) is never displayed in the UI (the color is set to yellow to indicate the warning field validation state, but the text message was not changed accordingly). Signed-off-by: Sharon Gratch <[email protected]>
sgratch
added a commit
to sgratch/forklift-console-plugin
that referenced
this pull request
Oct 3, 2023
As a followup for kubev2v#732, fix the oVirt provider's URL help text as follows: 1. Rephrase the error, warning and successful/initial text messages to be aligned with the documnetation, other providers fields and Patternfly error msg recommendations. 2. Set a url input ended with a "/" (i.e. "ovirt-engine/api/") as a valid url since it's mentioned on docs as valid and it's a common used case. 3. Fix a bug in which the waring text message string (helperTextMsgs.warning) is never displayed in the UI (the color is set to yellow to indicate the warning field validation state, but the text message was not changed accordingly). Signed-off-by: Sharon Gratch <[email protected]>
sgratch
added a commit
to sgratch/forklift-console-plugin
that referenced
this pull request
Oct 4, 2023
As a followup for kubev2v#732, fix the oVirt provider's URL help text as follows: 1. Rephrase the error, warning and successful/initial text messages to be aligned with the documnetation, other providers fields and Patternfly error msg recommendations. 2. Set a url input ended with a "/" (i.e. "ovirt-engine/api/") as a valid url since it's mentioned on docs as valid and it's a common used case. 3. Fix a bug in which the waring text message string (helperTextMsgs.warning) is never displayed in the UI (the color is set to yellow to indicate the warning field validation state, but the text message was not changed accordingly). Signed-off-by: Sharon Gratch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update oVIrt URL help message
Issue:
it's not clear if a user need to enter the schema and path when entring the URL
FIx:
a. add a better help text
b. add a warning state to alert users about missing path
Screenshots:
