MTV-1726: Edit VMs list in migration plan #1414
Conversation
| @@ -0,0 +1,149 @@ | |||
| import React, { useState } from 'react'; | |||
There was a problem hiding this comment.
this is basically a copy of packages/forklift-console-plugin/src/components/page/StandardPageWithSelection.tsx but without selection, only expansion
| @@ -0,0 +1 @@ | |||
| export type PlanEditAction = 'PLAN' | 'VMS'; | |||
There was a problem hiding this comment.
it will allow us next (with small changes like this) to edit plans too
| loadError: unknown; | ||
| loaded?: boolean; | ||
| loadError?: unknown; | ||
| planMappingsState: PlanMappingsSectionState; |
There was a problem hiding this comment.
I lifted the state up so that we can reuse planmappings from Edit VMs case
|
|
||
| import '../create/PlanCreatePage.style.css'; | ||
|
|
||
| export const PlanEditPage: React.FC<{ |
There was a problem hiding this comment.
initially copied from PlanCreatePage, but there were enough changes to make it its own component
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1414 +/- ##
==========================================
- Coverage 36.81% 36.21% -0.60%
==========================================
Files 158 159 +1
Lines 2548 2579 +31
Branches 599 615 +16
==========================================
- Hits 938 934 -4
- Misses 1428 1450 +22
- Partials 182 195 +13 ☔ View full report in Codecov by Sentry. |
[MTV-1686] Simplify/update migration plan status cell Signed-off-by: Joachim Schuler <[email protected]>
jschuler
force-pushed
the
mtv-1726_add-vms
branch
from
999f277 to
003bc27
Compare
Signed-off-by: Joachim Schuler <[email protected]>
|
https://issues.redhat.com/browse/MTV-1726
Design story:
https://issues.redhat.com/browse/HPUX-166
Provide users the possibility to add more VMs (not just delete) to an existing plan.
See this table below for when it is possible to do so.
Basically, whenever you can update plan mappings, you can also update plan VMs.
For the mappings section, I reused the plan details mappings tab section, since it can patch existing mappings
See video of before (green border)/after:
Screen.Recording.2024-12-13.at.12.04.40.PM.mov