[MTV-1769] Add Project field to migration plan/provider wizards #1409
+742
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpuzz0
force-pushed
the
MTV-1769-project-field
branch
from
87f0ce2 to
bb71fbb
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1409 +/- ##
==========================================
- Coverage 36.81% 36.21% -0.60%
==========================================
Files 158 159 +1
Lines 2548 2579 +31
Branches 599 615 +16
==========================================
- Hits 938 934 -4
- Misses 1428 1450 +22
- Partials 182 195 +13 ☔ View full report in Codecov by Sentry. |
jpuzz0
force-pushed
the
MTV-1769-project-field
branch
2 times, most recently
from
e8703d2 to
e7084ff
Compare
Signed-off-by: Jeff Puzzo <[email protected]>
jpuzz0
force-pushed
the
MTV-1769-project-field
branch
from
e7084ff to
640ac2d
Compare
|
yaacov
reviewed
Dec 17, 2024
yaacov
reviewed
Dec 17, 2024
...forklift-console-plugin/src/modules/Providers/views/create/components/ProviderCreateForm.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/MTV-1769
Summary
Updated the Provider & Plan create wizards to include a "Project" name typeahead select, where in the create plan wizard the options for this typeahead select are limited by the namespaces of the possible providers to choose from, and the create provider wizard simply gets all namespaces.
On submission of both wizards, the global (active) namespace is toggled to the selected "Project" namespace from the form (which could differ from the global/active namespace that was originally chosen upon entry of either wizard).
Further details of the logic implemented for the few fields re-arranged/in-play here are described in the acceptance criteria of this design story:
https://issues.redhat.com/browse/HPUX-259
Added a new TypeaheadSelect component that uses PFv5 components to the common internal library.
Create plan wizard
Create provider wizard