Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding typesense service #469

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: adding typesense service #469

wants to merge 3 commits into from

Conversation

cskiwi
Copy link
Contributor

@cskiwi cskiwi commented Nov 1, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Template (non-breaking change which adds a template)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • I've built the image and tested it on a kubernetes cluster

Test Configuration:

  • Operator Version:
  • Kubernetes Version:
  • Kubero CLI Version (if applicable):

Checklist:

  • I removed unnecessary debug logs
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I documented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@cskiwi
Copy link
Contributor Author

cskiwi commented Nov 1, 2024

After further thinking, this might be better as a add-on, what do you think @mms-gianni ?

@mms-gianni
Copy link
Member

This seems to me to be a borderline case. Both could be suitable. To make an add-on, we would need a Helm chart maintainer. Bitnami, for example.

But I like this template.

@mms-gianni mms-gianni self-assigned this Nov 1, 2024
@mms-gianni mms-gianni added the template A kubero template label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
template A kubero template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants