Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tasks/tls: add a page for manual CA rotation #21651

Merged
merged 1 commit into from
Jun 11, 2020
Merged

tasks/tls: add a page for manual CA rotation #21651

merged 1 commit into from
Jun 11, 2020

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Jun 11, 2020 •
edited
Loading

rework of the following PR to resolve conflicts:
#19351
(content is the same, fixed page / template formatting)

preview:
https://deploy-preview-21651--kubernetes-io-master-staging.netlify.app/docs/tasks/tls/manual-rotation-of-ca-certificates/

/sig auth cluster-lifecycle docs
/kind feature
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jun 11, 2020
@neolit123 neolit123 mentioned this pull request Jun 11, 2020
Closed
@neolit123
Copy link
Member Author

/assign @sftim
/cc @micahhausler @deads2k
cc @abhiTamrakar

@netlify
Copy link

netlify bot commented Jun 11, 2020 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 92b56db

https://deploy-preview-21651--kubernetes-io-master-staging.netlify.app

@sftim
Copy link
Contributor

sftim commented Jun 11, 2020

This looks ready for tech review

sftim
sftim reviewed Jun 11, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, one thing. Please adjust this to remove the {{% capture %}} shortcodes, now that #21359 has merged.

@neolit123
Copy link
Member Author

neolit123 commented Jun 11, 2020 •
edited
Loading

@sftim i guess it makes sense to have <!-- body --> &. <!-- overview --> for https://github.com/kubernetes/website/pull/21651/files#diff-f7024f94c2d9c79b0e5ce9a9c0f8aaa7
?

e.g. treating This page shows how to manually rotate the certificate authority (CA) certificates. as "overview"?

@sftim
Copy link
Contributor

sftim commented Jun 11, 2020

@sftim i guess it makes sense to have &. for https://github.com/kubernetes/website/pull/21651/files#diff-f7024f94c2d9c79b0e5ce9a9c0f8aaa7

Yes please, those comments are useful (they might help with future automation for example).

@abhiTamrakar @zacharysarah
@micahhausler @neolit123
manual steps for rotation of CA certificates.
92b56db 
Co-Authored-By: Zach Corleissen <[email protected]>
Co-authored-By: Micah Hausler <[email protected]>
@neolit123
Copy link
Member Author

neolit123 commented Jun 11, 2020 •
edited
Loading

@sftim i have updated the usage of "capture" tags.

@sftim
Copy link
Contributor

sftim commented Jun 11, 2020

OK, echoing #19351 (comment)

/lgtm
/approve

@abhiTamrakar thank you especially for the time you invested here.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit b635757 into kubernetes:master Jun 11, 2020
@neolit123 neolit123 mentioned this pull request Jun 11, 2020
Closed
@neolit123 neolit123 mentioned this pull request Jun 11, 2020
Closed
@abhiTamrakar
Copy link
Contributor

abhiTamrakar commented Jun 12, 2020 •
edited
Loading

Thanks @sftim for the help.
Thanks @neolit123 for fixing the conflicts.
Thanks @micahhausler for the guidance.

I hope this will benefit everyone on k8s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@jimangel jimangel Awaiting requested review from jimangel

@mikedanese mikedanese Awaiting requested review from mikedanese

@deads2k deads2k Awaiting requested review from deads2k

@micahhausler micahhausler Awaiting requested review from micahhausler

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neolit123 @sftim @k8s-ci-robot @abhiTamrakar