Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add helm/deps check for Alibaba Cloud CSI driver #34027

Merged
merged 1 commit into from
Dec 23, 2024
Merged

add helm/deps check for Alibaba Cloud CSI driver #34027

merged 1 commit into from
Dec 23, 2024

Conversation

huww98
Copy link
Contributor

@huww98 huww98 commented Dec 22, 2024

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config labels Dec 22, 2024
@k8s-ci-robot k8s-ci-robot added area/jobs size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 22, 2024
@huww98
Copy link
Contributor Author

huww98 commented Dec 22, 2024

/hold
merge after kubernetes-sigs/alibaba-cloud-csi-driver#1276

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2024
@huww98
Copy link
Contributor Author

huww98 commented Dec 23, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 23, 2024
@mowangdk
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huww98, mowangdk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6f3de8a into kubernetes:master Dec 23, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@huww98: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key alibaba-cloud-csi-driver.yaml using file config/jobs/kubernetes-sigs/alibaba-cloud-csi-driver/alibaba-cloud-csi-driver.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chases2 chases2 Awaiting requested review from chases2

@mowangdk mowangdk Awaiting requested review from mowangdk

Assignees

@mowangdk mowangdk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huww98 @mowangdk @k8s-ci-robot