Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune etcd presubmit jobs #32731

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Tune etcd presubmit jobs #32731

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c5ba94
Store etcd presubmit integration tests JUnit reports
ivanvc Jun 10, 2024
170c9be
Tune etcd presubmit integration 2 and 4 CPUs tests
ivanvc Jun 10, 2024
cd68949
Tune etcd presubmit unit 386 job
ivanvc Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions config/jobs/etcd/etcd-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ presubmits:

- name: pull-etcd-unit-test-386
cluster: eks-prow-build-cluster
optional: true # remove this once the job is green
always_run: true
branches:
- main
Expand All @@ -77,10 +76,10 @@ presubmits:
resources:
requests:
cpu: "4"
memory: "4Gi"
memory: "2Gi"
limits:
cpu: "4"
memory: "4Gi"
memory: "2Gi"

- name: pull-etcd-verify
cluster: eks-prow-build-cluster
Expand Down Expand Up @@ -168,6 +167,7 @@ presubmits:
- |
set -euo pipefail
make gofail-enable
export JUNIT_REPORT_DIR=${ARTIFACTS}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious on how this artifact dir is intended to work? Is there a bucket these artifacts will be stored in after the job has completed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They show up in the "Artifacts" tab of a build. For example, clicking "Artifacts" on build 1800476731895713792 takes you to the bucket. Inside there's an "artifacts" directory with the JUnit XML results.

I'm porting the following fragment, which seems to have been overlooked in the initial migration: https://github.com/etcd-io/etcd/blob/57907746e39da97ed3ce2fbd1f97e8ceb2ce8199/.github/workflows/tests-template.yaml#L69-L73.

However, I'm open to dropping saving the artifacts if we don't find value in storing them 🙂.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation (and for updating it into etcd-io/etcd docs with screenshot) this is great functionality lets continue to save these.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear and 100% transparent, the screenshots you saw were from the Robustness tests. These are JUnit results 😄

GOOS=linux GOARCH=amd64 CPU=1 make test-integration
resources:
requests:
Expand All @@ -179,7 +179,6 @@ presubmits:

- name: pull-etcd-integration-2-cpu-amd64
cluster: eks-prow-build-cluster
optional: true # remove this once the job is green
always_run: true
branches:
- main
Expand All @@ -198,18 +197,18 @@ presubmits:
- |
set -euo pipefail
make gofail-enable
export JUNIT_REPORT_DIR=${ARTIFACTS}
GOOS=linux GOARCH=amd64 CPU=2 make test-integration
resources:
requests:
cpu: "2"
memory: "8Gi"
cpu: "3"
memory: "3Gi"
limits:
cpu: "2"
memory: "8Gi"
cpu: "3"
memory: "3Gi"

- name: pull-etcd-integration-4-cpu-amd64
cluster: eks-prow-build-cluster
optional: true # remove this once the job is green
always_run: true
branches:
- main
Expand All @@ -228,14 +227,15 @@ presubmits:
- |
set -euo pipefail
make gofail-enable
export JUNIT_REPORT_DIR=${ARTIFACTS}
GOOS=linux GOARCH=amd64 CPU=4 make test-integration
resources:
requests:
cpu: "4"
memory: "8Gi"
cpu: "6"
memory: "3Gi"
limits:
cpu: "4"
memory: "8Gi"
cpu: "6"
memory: "3Gi"

- name: pull-etcd-robustness-amd64
cluster: k8s-infra-prow-build
Expand Down