Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add etcd robustness presubmit job #32729

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Add etcd robustness presubmit job #32729

merged 1 commit into from
Jun 12, 2024

Conversation

ArkaSaha30
Copy link
Member

This commit will migrate etcd robustness presubmit github action to presubmit prowjob for main branch.

Issue link: etcd-io/etcd#18136

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 10, 2024
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 10, 2024
@ArkaSaha30
Copy link
Member Author

ArkaSaha30 commented Jun 10, 2024 •
edited
Loading

cc @ivanvc @jmhbnz

@serathius
Copy link
Contributor

/lgtm
/hold
cc @jmhbnz

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2024
jmhbnz
jmhbnz reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArkaSaha30 looking good, just one tweak below before we merge.

config/jobs/etcd/etcd-presubmits.yaml Outdated Show resolved Hide resolved
@ArkaSaha30
Add etcd robustness presubmit job
9d2253d 
This commit will migrate etcd robustness presubmit
github action to presubmit prowjob for main branch.

Signed-off-by: ArkaSaha30 <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2024
ivanvc
ivanvc approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2024
jmhbnz
jmhbnz approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArkaSaha30, ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2024
@serathius
Copy link
Contributor

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit bd883e9 into kubernetes:master Jun 12, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@ArkaSaha30: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key etcd-presubmits.yaml using file config/jobs/etcd/etcd-presubmits.yaml

In response to this:

This commit will migrate etcd robustness presubmit github action to presubmit prowjob for main branch.

Issue link: etcd-io/etcd#18136

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@serathius serathius mentioned this pull request Jun 14, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius left review comments

@ivanvc ivanvc ivanvc approved these changes

@jmhbnz jmhbnz jmhbnz approved these changes

@ahrtr ahrtr Awaiting requested review from ahrtr

Assignees

@ivanvc ivanvc

@serathius serathius

@jmhbnz jmhbnz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ArkaSaha30 @serathius @k8s-ci-robot @ivanvc @jmhbnz