-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add needs-rebase plugin for etcd project #32724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/hold
One tiny comment, lgtm after that!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArkaSaha30, MadhavJivrajani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit will add `needs-rebase` plugin to etcd project which will add `needs-rebase` to a PR that requires a rebase and removes it once its rebased with the concered branch. Signed-off-by: ArkaSaha30 <[email protected]>
6bfd5ff
to
e0e50f4
Compare
/lgtm Thanks |
/hold cancel |
@ArkaSaha30: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR will add
needs-rebase
plugin to the etcd project which will addneeds-rebase
to a PR that requires a rebase and removes it once it's rebased with the concerned branch.Issue link: etcd-io/etcd#18110