-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add One Pager for the Release Signal Handbook #2615
base: master
Are you sure you want to change the base?
Add One Pager for the Release Signal Handbook #2615
Conversation
/cc @drewhagen @pacoxu @wendy-ha18 These are the initial things that occurred to me. I'm open to adding/removing things to simplify it. Feedback would be appreciated :) |
/hold |
Signed-off-by: Vyom-Yadav <[email protected]>
30986a9
to
c0b5b6a
Compare
/assign @justaugustus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one-pager!
👍
/lgtm
Hi @Vyom-Yadav , Great effort on this! I initially thought you would create a One Pager similar to the CI Signal One Pager, but I really like the diagram approach you used. Hope this diagram will be easy to maintain going forward. I have a few minor suggestions for the diagram. Feel free to review them in this note: One Pager Input. You’re welcome to ignore anything that seems too detailed for the One Pager purpose. Another point, which might be slightly outside the scope of this PR, before looking at your diagram I have reviewed the Release Path on Release team Handbook (particularly for Release Signal process).
Just some thoughts, hope this helps! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job updating this! What do you use to update these .svgs? I'm curious in case I want to update something myself in the future.
It looks like there is also a table in the release-team doc that uses this .svg that can also be updated. It has links to CI Signal and Bug Triage one pagers. We could probably remove those and link Release Signal to this one :)
I agree with @wendy-ha18 - this gets a bit adjacent to your contribution that we're reviewing @Vyom-Yadav, but nonetheless while we're updating the SIG Release README, the CI Signal process should probably be moved sooner in the visual release path. (I think the original thought was that flakes and failures would come out of code development that follows after enhancement freeze? But actually, a lot of tracked flakes, failures and code implementations carry over from past milestones, so test grid observation can begin right away) |
E --> F["Message #release-signal Slack channel"] | ||
F --> G["Reach out to SIG on Slack"] | ||
G --> H["Ping SIG TLs/Chairs/Active Members"] | ||
H --> I["Ask if it's a blocker for upcoming release"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
H --> I["Ask if it's a blocker for upcoming release"] | |
H --> I["Ask if it's a blocker for upcoming release cut"] |
credit goes to @wendy-ha18 for this feedback. It makes it a bit more clear to focus the ask on the next upcoming cut.
## Release Signal - Testgrid Observation Loop | ||
|
||
```mermaid | ||
flowchart TD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just want to clarify my interpretation: this flowchart is sort of the lifecycle of an individual flake/failure issue, right?
Really great job @Vyom-Yadav! I appreciate you putting this together. I think these diagrams cover the most frequent day to day operations, which will be really helpful for the team to understand. This also really compliments the full handbook well, that covers all other tasks with more details. The current handbook is also organized into sections well enough that the lead could always guide shadows by sharing anchor links of sections when less common tasks come up. |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: drewhagen, Vyom-Yadav The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this:
/kind documentation
What this PR does / why we need it:
The Release Signal Handbook is quite long. These diagrams in one pager aim to provide a quick overview of the process to simplify things.
Which issue(s) this PR fixes:
Fixes #2612
Special notes for your reviewer: