Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release notes todos section and add debugging tips #2500

Merged
merged 3 commits into from
May 24, 2024
Merged

Update release notes todos section and add debugging tips #2500

merged 3 commits into from
May 24, 2024

Conversation

npolshakova
Copy link
Contributor

@npolshakova npolshakova commented May 10, 2024 •
edited
Loading

What type of PR is this:

/kind documentation

What this PR does / why we need it:

Adds a common debug section and updates the TODOs section based on 1.30 improvement discussions: https://kubernetes.slack.com/archives/CN1KH4K9A/p1706942615321299?thread_ts=1706900606.161789&cid=CN1KH4K9A

Which issue(s) this PR fixes:

#2498

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels May 10, 2024
@k8s-ci-robot k8s-ci-robot added area/release-team Issues or PRs related to the release-team subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 10, 2024
ramrodo
ramrodo suggested changes May 12, 2024
View reviewed changes
Copy link
Member

@ramrodo ramrodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Nina.

Just a small suggestion for a typo.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 20, 2024
@ramrodo
Copy link
Member

ramrodo commented May 20, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2024
@rashansmith
Copy link
Contributor

/approve

@rashansmith
Copy link
Contributor

/assign @ramrodo

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2024
@ramrodo
Copy link
Member

ramrodo commented May 24, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: npolshakova, ramrodo, rashansmith

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2024
@k8s-ci-robot k8s-ci-robot merged commit 98e587d into kubernetes:master May 24, 2024
2 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashansmith rashansmith rashansmith approved these changes

@harshanarayana harshanarayana Awaiting requested review from harshanarayana

@ramrodo ramrodo Awaiting requested review from ramrodo

Assignees

@ramrodo ramrodo

@rashansmith rashansmith

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
4 participants
@npolshakova @ramrodo @rashansmith @k8s-ci-robot