-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sig-storage: sync team members & OWNERS of external-snapshot-metadata #5392
base: main
Are you sure you want to change the base?
sig-storage: sync team members & OWNERS of external-snapshot-metadata #5392
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Rakshith-R The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @Rakshith-R! |
Hi @Rakshith-R. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Please take a look. |
config/kubernetes-csi/org.yaml
Outdated
- carlbraganza | ||
- PrasadG193 | ||
- hairyhum | ||
- rakshith-r |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think being added to the external-snapshot-metadata-maintainers group should be sufficient for cutting releases.
Since ihcsim is no longer active, can you remove him and replace him with another person (not adding so many people to admin group)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think being added to the external-snapshot-metadata-maintainers group should be sufficient for cutting releases. Since ihcsim is no longer active, can you remove him and replace him with another person (not adding so many people to admin group)?
okay,
I've added only @carlbraganza instead.
Please take a look.
8a98fbb
to
668168d
Compare
/ok-to-test |
/lgtm |
…o OWNERS This commit syncs external-snapshot-metadata repo OWNERS with the corresponding external-snapshot-metadata-maintainers and external-snapshot-metadata-admins teams. This is required in order for the missing members to be able to create release branches and tag releases. refer: - https://github.com/kubernetes-csi/external-snapshot-metadata/blob/main/OWNERS - https://github.com/orgs/kubernetes-csi/teams/external-snapshot-metadata-maintainers - https://github.com/orgs/kubernetes-csi/teams/external-snapshot-metadata-admins Signed-off-by: Rakshith R <[email protected]>
668168d
to
9600370
Compare
New changes are detected. LGTM label has been removed. |
Sorted the list to fix the test failure. please take a look again. |
/cc @xing-yang |
This commit syncs external-snapshot-metadata repo OWNERS with the corresponding external-snapshot-metadata-maintainers and external-snapshot-metadata-admins teams.
This is required in order for the missing members to be able to create release branches and tag releases.
refer: