Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sig-storage: sync team members & OWNERS of external-snapshot-metadata #5392

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Rakshith-R
Copy link

This commit syncs external-snapshot-metadata repo OWNERS with the corresponding external-snapshot-metadata-maintainers and external-snapshot-metadata-admins teams.

This is required in order for the missing members to be able to create release branches and tag releases.

refer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Rakshith-R
Once this PR has been reviewed and has the lgtm label, please assign priyankasaggu11929 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/github-management Issues or PRs related to GitHub Management subproject label Feb 10, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @Rakshith-R!

It looks like this is your first PR to kubernetes/org 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/org has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 10, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @Rakshith-R. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 10, 2025
@Rakshith-R
Copy link
Author

Please take a look.
/cc @xing-yang

@carlbraganza @PrasadG193 @hairyhum ^

- carlbraganza
- PrasadG193
- hairyhum
- rakshith-r
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think being added to the external-snapshot-metadata-maintainers group should be sufficient for cutting releases.
Since ihcsim is no longer active, can you remove him and replace him with another person (not adding so many people to admin group)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think being added to the external-snapshot-metadata-maintainers group should be sufficient for cutting releases. Since ihcsim is no longer active, can you remove him and replace him with another person (not adding so many people to admin group)?

okay,
I've added only @carlbraganza instead.
Please take a look.

@Rakshith-R Rakshith-R force-pushed the update-snapshot-metadata-teams branch from 8a98fbb to 668168d Compare February 13, 2025 10:46
@Rakshith-R Rakshith-R requested a review from xing-yang February 13, 2025 10:47
@xing-yang
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 13, 2025
@xing-yang
Copy link
Contributor

cc @saad-ali @msau42 @jsafrane

@xing-yang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2025
…o OWNERS

This commit syncs external-snapshot-metadata repo OWNERS
with the corresponding external-snapshot-metadata-maintainers
and external-snapshot-metadata-admins teams.

This is required in order for the missing members to be able to
create release branches and tag releases.

refer:
- https://github.com/kubernetes-csi/external-snapshot-metadata/blob/main/OWNERS
- https://github.com/orgs/kubernetes-csi/teams/external-snapshot-metadata-maintainers
- https://github.com/orgs/kubernetes-csi/teams/external-snapshot-metadata-admins

Signed-off-by: Rakshith R <[email protected]>
@Rakshith-R Rakshith-R force-pushed the update-snapshot-metadata-teams branch from 668168d to 9600370 Compare February 13, 2025 14:33
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@Rakshith-R
Copy link
Author

@Rakshith-R: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-org-test-all 668168d link true /test pull-org-test-all
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

    config_test.go:268: The team external-snapshot-metadata-maintainers in org Kubernetes CSI has an unsorted list of members
    config_test.go:268: The team external-snapshot-metadata-admins in org Kubernetes CSI has an unsorted list of members

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/org/5392/pull-org-test-all/1890043871077863424

Sorted the list to fix the test failure.

please take a look again.

@Rakshith-R
Copy link
Author

/cc @xing-yang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants