Add support for AMD GPUs via --gpus=amd

[fbyrne]

Add support for AMD GPUs via --gpus=amd

Fixes #19463

Before: minikube start --help

minikube start --help
...
    -g, --gpus='':
        Allow pods to use your NVIDIA GPUs. Options include: [all,nvidia] (Docker driver with Docker container-runtime
        only)

After: minikube start --help

minikube start --help
...
    -g, --gpus='':
        Allow pods to use your GPUs. Options include: [all,nvidia,amd] (Docker driver with Docker
        container-runtime only)

[k8s-ci-robot]

Hi @fbyrne. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[minikube-bot]

Can one of the admins verify this patch?

[spowelljr]

Thanks for the PR!

[fbyrne]

Hi @spowelljr, applied all suggestions and updated tests. if this is good to go, ill squash and push again.

[spowelljr]

/ok-to-test

[spowelljr]

Seeing failures for the AmdGpuDevicePlugin test, could you look into them @fbyrne

[fbyrne]

Yeah I'll take a look at them tonight.

How do I run the tests that are failing locally?

[spowelljr]

Can see https://minikube.sigs.k8s.io/docs/contrib/testing/ for the full documentation, but make integration -e TEST_ARGS="-test.run TestAddons" should just run what you need.

Ignore the TestAddons/serial/GCPAuth/PullSecret btw, that's known and I'm resolving it

If you want to run faster iteration loops you can comment out/delete the other addons

diff --git a/test/integration/addons_test.go b/test/integration/addons_test.go
index 9bf9d3a2d..9975458a5 100644
--- a/test/integration/addons_test.go
+++ b/test/integration/addons_test.go
@@ -121,8 +121,6 @@ func TestAddons(t *testing.T) {
                        name      string
                        validator validateFunc
                }{
-                       {"Volcano", validateVolcanoAddon},
-                       {"GCPAuth", validateGCPAuthAddon},
                }
                for _, tc := range tests {
                        tc := tc
@@ -141,17 +139,6 @@ func TestAddons(t *testing.T) {
                        name      string
                        validator validateFunc
                }{
-                       {"Registry", validateRegistryAddon},
-                       {"Ingress", validateIngressAddon},
-                       {"InspektorGadget", validateInspektorGadgetAddon},
-                       {"MetricsServer", validateMetricsServerAddon},
-                       {"Olm", validateOlmAddon},
-                       {"CSI", validateCSIDriverAndSnapshots},
-                       {"Headlamp", validateHeadlampAddon},
-                       {"CloudSpanner", validateCloudSpannerAddon},
-                       {"LocalPath", validateLocalPathAddon},
-                       {"NvidiaDevicePlugin", validateNvidiaDevicePlugin},
-                       {"Yakd", validateYakdAddon},
                }
                for _, tc := range tests {
                        tc := tc

[fbyrne]

Should be good now, rebased to remove conflict.

[fbyrne]

/ok-to-test

[spowelljr]

You'll need to only run the test on amd64, it's running on arm64 tests as well and failing.

[fbyrne]

Good morning, yeah I saw those failures, last fix pushed was a fix to only add when driver is docker and amd64 arch.

[fbyrne]

@spowelljr, if the PR is good, ill squash to tidy the history. let me know

[spowelljr]

Looks good to me, feel free to squash @fbyrne

[fbyrne]

👍 Squashed

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19749) |
+----------------+----------+---------------------+
| minikube start | 46.9s    | 47.4s               |
| enable ingress | 15.8s    | 16.5s               |
+----------------+----------+---------------------+

Times for minikube start: 49.0s 44.5s 48.6s 47.8s 44.5s
Times for minikube (PR 19749) start: 47.3s 48.1s 49.0s 47.2s 45.4s

Times for minikube ingress: 18.9s 14.4s 14.9s 14.9s 15.9s
Times for minikube (PR 19749) ingress: 18.9s 15.4s 14.4s 15.4s 18.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19749) |
+----------------+----------+---------------------+
| minikube start | 21.0s    | 21.6s               |
| enable ingress | 12.4s    | 12.6s               |
+----------------+----------+---------------------+

Times for minikube start: 19.9s 19.9s 19.9s 23.1s 22.5s
Times for minikube (PR 19749) start: 22.8s 20.4s 19.5s 22.6s 22.8s

Times for minikube ingress: 12.2s 12.7s 12.2s 12.2s 12.7s
Times for minikube (PR 19749) ingress: 12.7s 12.7s 12.7s 12.7s 12.2s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19749) |
+----------------+----------+---------------------+
| minikube start | 21.0s    | 20.0s               |
| enable ingress | 38.8s    | 32.9s               |
+----------------+----------+---------------------+

Times for minikube ingress: 39.2s 38.8s 38.7s 38.7s 38.7s
Times for minikube (PR 19749) ingress: 23.2s 39.2s 39.7s 39.2s 23.2s

Times for minikube start: 22.0s 19.9s 21.6s 22.2s 19.3s
Times for minikube (PR 19749) start: 19.8s 19.6s 19.0s 19.2s 22.5s

[minikube-pr-bot]

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment	Test Name	Flake Rate

Besides the following environments also have failed tests:

• Docker_Linux_crio: 2 failed (gopogh)

• KVM_Linux_crio: 31 failed (gopogh)

• Hyper-V_Windows: 15 failed (gopogh)

• QEMU_macOS: 99 failed (gopogh)

• Hyperkit_macOS: 15 failed (gopogh)

• Docker_Cloud_Shell: 3 failed (gopogh)

• Docker_Linux_crio_arm64: 2 failed (gopogh)

• Docker_Windows: 2 failed (gopogh)

• Docker_Linux_containerd_arm64: 2 failed (gopogh)

To see the flake rates of all tests by environment, click here.

[spowelljr]

Thanks for the PR!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbyrne, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment