-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: #2501 Count volumes attached to a node #2810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: #2501 Count volumes attached to a node #2810
Conversation
…node # Conflicts: # internal/store/node_test.go
…ached-to-a-node
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LiuQhahah The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/triage accepted |
|
Would you mind sharing the use case of this? |
TLDR: The number of volumes that can be attached to a Node is hard-limited for different hosting providers and thus should be monitored and alerted when approaching the limit. |
What this PR does / why we need it:
Count volumes attached to a node
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
increaser two metrics: kube_node_volumes_attached_count and kube_node_volumes_in_use_count
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #2501