-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: fix named volume detection logic #1944
base: main
Are you sure you want to change the base?
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @ms-jpq! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Thank you so much for this fix!
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdrage, ms-jpq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Failing tests :( are you able to check the failed |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently an input with a named volume defined in the same
docker-compose.yml
would produce an error like so:minimal example:
This bug was introduced here, the code for checking say
/app/data
in the example below, neglected to account for volumes like the one shown above.This PR simply adds a check to
data:
, as indata:/app/data
, where as currently this is treated identically to just/app/data
.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: