Skip to content

Add secret rotator #7964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Apr 5, 2025
Merged

Add secret rotator #7964

k8s-ci-robot merged 1 commit into from
Apr 5, 2025

Conversation

@mkumatag
Copy link
Member

@mkumatag mkumatag commented Apr 5, 2025

This PR adds the following resources

  • Adds a external secret for secret-manager
  • The secret-manager cron job that runs every two hours to rotate the secrets aggressively and mitigate potential leaks.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 5, 2025
@k8s-ci-robot k8s-ci-robot requested review from cjwagner and pohly April 5, 2025 08:19
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 5, 2025
@mkumatag
Copy link
Member Author

mkumatag commented Apr 5, 2025

/cc @upodroid @Prajyot-Parab

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit 245816b into kubernetes:main Apr 5, 2025
3 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@upodroid upodroid upodroid approved these changes

@cjwagner cjwagner Awaiting requested review from cjwagner

@pohly pohly Awaiting requested review from pohly

@Prajyot-Parab Prajyot-Parab Awaiting requested review from Prajyot-Parab

Assignees

@upodroid upodroid

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.33

Development

Successfully merging this pull request may close these issues.

3 participants

@mkumatag @k8s-ci-robot @upodroid