Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Atlantis #7520

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Deploy Atlantis #7520

wants to merge 4 commits into from
+119 −0

Conversation

upodroid
Copy link
Member

I'm deploying Atlantis to enable Terraform PR automation. Details: https://www.runatlantis.io

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters labels Nov 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 14, 2024
@upodroid
Copy link
Member Author

/retest

@upodroid upodroid mentioned this pull request Nov 20, 2024
Merged
@upodroid upodroid added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 24, 2024
@upodroid upodroid changed the title WIP - Deploy Atlantis Deploy Atlantis Nov 24, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2024
@upodroid
Copy link
Member Author

/cc @ameukam @BenTheElder

This is ready to be merged. Atlantis is up and running, but I'll add the privileges for GCP/AWS in a separate PR.

  1. Atlantis will only accept commands from members of @kubernetes/sig-k8s-infra
  2. https://atlantis.k8s.io is accessible for any member of @kubernetes GitHub org except the /events path.
  3. Atlantis is configured to verify webhook as described here https://docs.github.com/en/webhooks/using-webhooks/validating-webhook-deliveries hence anyone can access https://atlantis.k8s.io/events

Have a look #7522 for an example.

@ameukam
Copy link
Member

ameukam commented Nov 24, 2024

/lgtm
/hold

For Ben's review

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2024
ameukam
ameukam reviewed Nov 24, 2024
View reviewed changes
kubernetes/gke-utility/atlantis/atlantis.yaml
@@ -0,0 +1,8 @@
gh-user: k8s-infra-ci-robot
gh-org: kubernetes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this imply Atlantis can interact with the Github org ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameukam ameukam ameukam left review comments

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@upodroid @k8s-ci-robot @ameukam