Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OWNERS for k8s.gcr.io/k8s-staging-capi-openstack #361

Merged
merged 2 commits into from
Sep 12, 2019

Conversation

sbueringer
Copy link
Member

Adds OWNERS files for capo related staging directories. Approvers are based on the active approvers for the code repo: https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/master/OWNERS_ALIASES#L21

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 9, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @sbueringer. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 9, 2019
@k8s-ci-robot k8s-ci-robot added wg/k8s-infra do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Sep 9, 2019
@sbueringer
Copy link
Member Author

sbueringer commented Sep 9, 2019

@dims

The following users are mentioned in OWNERS file(s) but are not members of the kubernetes org.

Once all users have been added as members of the org, you can trigger verification by writing /verify-owners in a comment.

  • sbueringer

    • k8s.gcr.io/k8s-staging-capi-openstack/OWNERS
  • jichenic

    • k8s.gcr.io/k8s-staging-capi-openstack/OWNERS

@dims We are both members of the kubernetes-sigs org. I saw a discussion a while ago about if a membership in one of the Kubernetes orgs (kubernetes and kubernetes-sigs) implies the same in the other org. Do you know what the current status is?

@dims
Copy link
Member

dims commented Sep 9, 2019

@sbueringer can you please open an issue in https://github.com/kubernetes/org/ to ask? (also jichenic should be @jichenjc right?)

@sbueringer
Copy link
Member Author

/verify-owners

@sbueringer
Copy link
Member Author

@sbueringer can you please open an issue in https://github.com/kubernetes/org/ to ask? (also jichenic should be @jichenjc right?)

Yup, you're right, I adjusted the OWNER file. Now it's only me who is missing in the Kubernetes org :). I've opened an issue here: kubernetes/org#1169

@sbueringer
Copy link
Member Author

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 11, 2019
@sbueringer
Copy link
Member Author

@dims Prow is happy now :), not sure if there's anything else to do from my side

@dims
Copy link
Member

dims commented Sep 12, 2019

/ok-to-test
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit dd7b187 into kubernetes:master Sep 12, 2019
@sbueringer sbueringer deleted the pr-add-capo-owner branch September 12, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants