Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nginx-go-crossplane on template rendering #11975

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Use nginx-go-crossplane on template rendering #11975

wants to merge 29 commits into from
+6,503 −1,254

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Sep 15, 2024

What this PR does / why we need it:

This is the Xnd part of moving to use nginx go crossplane. Now adding mirrors, custom error, initial server bootstrap, etc
Also stream and mod_security are removed from here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 15, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 15, 2024
@rikatz rikatz force-pushed the more-crossplane branch 5 times, most recently from 2479b96 to 8ec5d8f Compare September 29, 2024 22:54
@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. area/docs area/helm Issues or PRs related to helm charts needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 29, 2024
@rikatz rikatz changed the base branch from feature-go-crossplane to main September 29, 2024 22:58
@k8s-ci-robot k8s-ci-robot removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify Netlify
Copy link

netlify bot commented Sep 29, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-ingress-nginx ready!

Name Link
🔨 Latest commit dcc64c2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/671ef302144b1b0008e0a90a
😎 Deploy Preview https://deploy-preview-11975--kubernetes-ingress-nginx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rikatz rikatz changed the title Bootstrap server configs and a bunch of other configs Use nginx-go-crossplane on template rendering Sep 29, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2024
Gabriel M. Dutra and others added 25 commits October 28, 2024 02:10
@rikatz
crossplane: Add brotli and proxy_hide_header (kubernetes#11678)
191b5d3 
Signed-off-by: Gabriel M. Dutra <[email protected]>
@MrErlison @rikatz
Fix move nested if statement (kubernetes#11688)
c004b56
@MrErlison @rikatz
Add tests for tags with custom values (kubernetes#11686)
f72cc8d 
* Add tests for tags with custom values

* Fix typo in comments
@rikatz
crossplane: Add test to 'proxy_hide_header' directive (kubernetes#11687)
4179805 
Signed-off-by: Gabriel M. Dutra <[email protected]>
@rikatz
Add brotli module parser (kubernetes#11690)
d7efdf0
@rikatz
Add upstream directives and some others (kubernetes#11681)
5086a96
@MrErlison @rikatz
Add CustomHTTPErrors directive (kubernetes#11699)
27dfcff 
* Add CustomHTTPErrors directive

* Fix: Add missing '=' in error_page directive
@rikatz
Continue go crossplane (kubernetes#11964)
fa45a30
@rikatz
Bootstrap server configs and a bunch of other configs
0c3de03
@rikatz
Start moving location auth
1b13799
@rikatz
Finalize external auth and cors
a438fc0
@rikatz
Do more crossplane migration
6411ba6
@rikatz
Add some more directives
040174d
@rikatz
Test crossplane
659a9b6
@rikatz
fix bugs on crossplane
fd0fce6
@rikatz
Fix location generator and some other bugs
86e2f12
@rikatz
Fix test parsing
d9aa10e
@rikatz
Start adding flags to crossplane tests
4d71ae7
@rikatz
Fix more tests and wrong configs
030795b
@rikatz
Fix more crossplane and tests
ab58613
@rikatz
Add Opentelemetry module
7a0c42b
@rikatz
Add new modules to crossplane
2cd213b
@rikatz
fixing more stuff on crossplane
1f608b9
@rikatz
Almost finished crossplane
c8c73b0
@rikatz
Fix auth parts
83eb001
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrErlison MrErlison Awaiting requested review from MrErlison

@Gacko Gacko Awaiting requested review from Gacko

@puerco puerco Awaiting requested review from puerco

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docs area/helm Issues or PRs related to helm charts cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rikatz @k8s-ci-robot @nulldutra @MrErlison