-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build NGINX v1.25 image #10629
Build NGINX v1.25 image #10629
Conversation
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few nits
I will come back to this PR this week. My plan is to get it merged, publishing on ghcr and then running e2e against this as a base |
647c450
to
5516c06
Compare
06d7bf3
to
ab877dd
Compare
7fc69f9
to
21fe035
Compare
3114560
to
a3cb45c
Compare
a3cb45c
to
1bbf24b
Compare
94b398d
to
2fbe413
Compare
2fbe413
to
aa60789
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
let's go!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, strongjz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: