-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backends.GetProtocol func for mixed protocol #2739
base: master
Are you sure you want to change the base?
Add backends.GetProtocol func for mixed protocol #2739
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TortillaZHawaii The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @TortillaZHawaii. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Also injects EnableL4MixedProtocol feature flag to L4 ILB.
0bee76e
to
6e39947
Compare
/assign @mmamczur |
/ok-to-test |
Similar to #2733, but this one only looks at the service definitions, for single protocol it won't change anything, so for example TCP will still have TCP backend, but when both TCP and UDP services are used it will use L3 backend service.