Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove maintainer labels in Dockerfiles since they just get stale #7490

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

raywainman
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Removes the maintainer label from all our Dockerfiles, these values just get stale and can be misleading. They are optional labels added to the built images.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/balancer labels Nov 12, 2024
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler area/vertical-pod-autoscaler size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 12, 2024
@raywainman
Copy link
Contributor Author

/assign kwiesmueller

@adrianmoisey
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2024
@kwiesmueller
Copy link
Member

/lgtm
/approve

@Shubham82
Copy link
Contributor

This PR needs approval from each Project Approver.

cc @x13n @MaciekPytel @kgolab @mwielgus

PTAL!

@raywainman
Copy link
Contributor Author

/assign maciekpytel

@x13n
Copy link
Member

x13n commented Nov 15, 2024

/lgtm
/approve

@raywainman
Copy link
Contributor Author

/assign gjtempleton

@gjtempleton
Copy link
Member

Thanks.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, kwiesmueller, raywainman, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3080b95 into kubernetes:master Nov 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/balancer area/cluster-autoscaler area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants